[PATCH] D68705: [llvm-readelf/llvm-readobj] - Improve dumping of broken versioning sections.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 30 08:06:13 PDT 2019


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Looks good to me, aside from some minor comments.



================
Comment at: llvm/test/tools/llvm-readobj/elf-invalid-versioning.test:195
+## the .dynstr, which is 1. We create a custom string table .mystrtab of size 1
+## and link it with the .gnu.version_r. For the vna_name we use same trick.
+
----------------
"with the .gnu.version_r section."
"we use the same"


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68705/new/

https://reviews.llvm.org/D68705





More information about the llvm-commits mailing list