[PATCH] D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 29 09:19:12 PDT 2019


aprantl added inline comments.


================
Comment at: llvm/lib/IR/DebugInfoMetadata.cpp:1142
       default: break;
+      case dwarf::DW_OP_shr:
       case dwarf::DW_OP_plus:
----------------
Should this be a separate commit? This seems unrelated to the SDag change?


================
Comment at: llvm/test/CodeGen/ARM/fragmented-args-multiple-regs.ll:35
+attributes #0 = { norecurse nounwind readnone "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "min-legal-vector-width"="0" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="generic" "target-features"="+armv7-a,+dsp,+neon,+vfp3,-thumb-mode" "unsafe-fp-math"="false" "use-soft-float"="false" }
+attributes #1 = { nounwind readnone speculatable }
+
----------------
djtodoro wrote:
> And this as well.
Still needs to happen.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61184/new/

https://reviews.llvm.org/D61184





More information about the llvm-commits mailing list