[PATCH] D69399: [yaml2obj/obj2yaml] - Add support for SHT_GNU_HASH section.
    George Rimar via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Wed Oct 30 05:18:28 PDT 2019
    
    
  
grimar added inline comments.
================
Comment at: llvm/test/tools/yaml2obj/elf-gnu-hash-section.yaml:137
+Sections:
+  - Name:  .gnu.hash.only.header
+    Type:  SHT_GNU_HASH
----------------
jhenderson wrote:
> .gnu.hash.no.header?
Right, thanks.
================
Comment at: llvm/test/tools/yaml2obj/elf-gnu-hash-section.yaml:260
+
+## Test we can override the number of buckets and the number of words in the bloom filter
+## using the "NBuckets" and "Shift2" keys.
----------------
jhenderson wrote:
> This bloom hasn't been changed to Bloom.
Done. Sorry.
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69399/new/
https://reviews.llvm.org/D69399
    
    
More information about the llvm-commits
mailing list