[PATCH] D69556: [CodeGen] Move ARMCodegenPrepare to TypePromotion

[Sam Parker via Phabricator via llvm-commits]

samparker marked an inline comment as done.
samparker added subscribers: asb, atanasyan.
samparker added a comment.

Thanks both, yes I'll get some numbers for AArch64 as well as more for ARM... @asb and @atanasyan  would you be interested in getting some numbers for your targets?



================
Comment at: lib/CodeGen/TypePromotion.cpp:47
 static cl::opt<bool>
-DisableCGP("arm-disable-cgp", cl::Hidden, cl::init(true),
-           cl::desc("Disable ARM specific CodeGenPrepare pass"));
-
-static cl::opt<bool>
-EnableDSP("arm-enable-scalar-dsp", cl::Hidden, cl::init(false),
-          cl::desc("Use DSP instructions for scalar operations"));
-
-static cl::opt<bool>
-EnableDSPWithImms("arm-enable-scalar-dsp-imms", cl::Hidden, cl::init(false),
-                   cl::desc("Use DSP instructions for scalar operations\
-                            with immediate operands"));
+DisablePromotion("disable-type-promotion", cl::Hidden, cl::init(true),
+                 cl::desc("Disable type promotion pass"));
----------------
craig.topper wrote:
> So this pass is off by default on ARM?
We've had it on downstream for about a year now and I've been bug fixing. I now want to enable it by default, but also generalise it first.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69556/new/

https://reviews.llvm.org/D69556