[PATCH] D69572: [ELF][test] Change referenceds of %T to %t.dir

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 30 02:12:34 PDT 2019


jhenderson accepted this revision.
jhenderson added a comment.

LGTM. I don't know if you did, but this might be a good case for deleting the test output directory and then rerunning the tests, to make sure you didn't miss anything subtle in the tests that are working only because of old files lying around.



================
Comment at: lld/test/ELF/reproduce-backslash.s:1
 # REQUIRES: x86, shell
 
----------------
Aside: Shouldn't this be `REQUIRES: x86, system-linux` (or whatever the equivalent is), rather than `REQUIRES: x86, shell`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69572/new/

https://reviews.llvm.org/D69572





More information about the llvm-commits mailing list