[PATCH] D69027: [llvm-dwarfdump][Statistics] Fix calculation of OffsetToFirstDefinition

[Alexey Lapshin via Phabricator via llvm-commits]

avl added a comment.

> Doesn't the absolute number of covered bytes (i.e. ScopeBytesCovered) suite this purpose? Yes, we will see no change in coverage, but the absolute number will be changed from 14 to 97 bytes, which may be considered as an improvement. Does it make sense to you?

I think absolute number of covered bytes is not enough here. There should be explicit change in coverage coefficient.

> (Alexey @avl, please, correct me if I'm wrong here), Alexey suggests either

my suggestion is that we need not trimmed coverage for

GlobalStats.ScopeBytesCovered += std::min(BytesInScope, BytesCovered);
GlobalStats.ScopeBytes += BytesInScope;
GlobalStats.ParamScopeBytesCovered += std::min(BytesInScope, BytesCovered);
GlobalStats.ParamScopeBytes += BytesInScope;
GlobalStats.VarScopeBytesCovered += std::min(BytesInScope, BytesCovered);
GlobalStats.VarScopeBytes += BytesInScope;

and for collectLocStats.

As to the #2 and #3 - they could probably be done later.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69027/new/

https://reviews.llvm.org/D69027