[PATCH] D69593: [libFuzzer] don't use /dev/null for DiscardOuput in Fuchsia.
Marco Vanotti via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 29 15:50:56 PDT 2019
charco added a comment.
Hi Reviewers!
I have two versions of this change:
This version adds an ifdef guard to specialize the code for fuchsia, and I have another set of changes that fork FuzzerIOPosix into FuzzerIOFuchsia and adds the specialized version there:
- https://reviews.llvm.org/D69082
- https://reviews.llvm.org/D69084
Please review whichever you think it the best approach. So far, the only thing that has been causing issues in FuzzerIOPosix for Fuchsia is /dev/null usage, I am not sure whether there will be other changes that would justify the fork of this file. There's some usage of the getDevNull function that we also need to address, but that could be handled in fuchsia specific code (checking if some path == getDevNull, or refactoring the code to not assume that there is a devnull-like file).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69593/new/
https://reviews.llvm.org/D69593
More information about the llvm-commits
mailing list