[PATCH] D69581: AMDGPU/GlobalISel: Legalize FDIV32

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:2024
+
+  auto One = B.buildFConstant({S32}, 1.0f);
+
----------------
You shouldn't need the {} around the types, same goes for the rest of the function


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:2044
+
+  if (!ST.hasFP32Denormals())
+    toggleSPDenormMode(true, ST, B, Flags);
----------------
Can you add a FIXME here since this doesn't correctly model the FP mode switch, and the FP operations aren't modeled as reading it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69581/new/

https://reviews.llvm.org/D69581