[PATCH] D69576: [sanitizer_common] Create max_allocation_size_mb flag.

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 29 13:11:14 PDT 2019


eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: compiler-rt/lib/asan/asan_allocator.cpp:444
+    if (size > kMaxAllowedMallocSize || needed_size > kMaxAllowedMallocSize ||
+        size > max_user_defined_malloc_size) {
       if (AllocatorMayReturnNull()) {
----------------
morehouse wrote:
> eugenis wrote:
> > Do we need this  check as well?
> > needed_size > max_user_defined_malloc_size
> I *think* we only want to check `size` here, but I'm not sure.  @kcc Does Mozilla care about ASan metadata and alignment padding for this limit?
Makes sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69576/new/

https://reviews.llvm.org/D69576





More information about the llvm-commits mailing list