[PATCH] D69546: [SanitizerCommon] Print the current value of options when printing out help.
Dan Liew via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 29 11:14:01 PDT 2019
delcypher marked 5 inline comments as not done.
delcypher added inline comments.
================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_flag_parser.h:78
+ str_to_use = reinterpret_cast<const char *>(false_str);
+ }
+ if (size < copy_count)
----------------
eugenis wrote:
> const char *str = *t_ ? "true" : "false;
> uptr copy_count = internal_strnlen(str, size);
>
That's a lot more concise. I'll go with that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69546/new/
https://reviews.llvm.org/D69546
More information about the llvm-commits
mailing list