[PATCH] D29121: [Docs] Add LangRef documention for freeze instruction
Philip Reames via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 29 11:04:37 PDT 2019
reames added a comment.
In D29121#1724593 <https://reviews.llvm.org/D29121#1724593>, @nlopes wrote:
> In D29121#1723978 <https://reviews.llvm.org/D29121#1723978>, @jdoerfert wrote:
>
> > So this is not committed till we reviewed all of them?
>
>
> I'm just waiting on SelDAG->MIR patch to be done (https://reviews.llvm.org/D29014).
> Then we have docs, SelDAG & MIR support. That seems the minimal to me (so the compiler won't crash when freeze is used). I agree the optimizer patches can land later.
Can I suggest that we add a stub* ISEL implementation, land this, and then build on top of it?
- By which I mean a knowingly incorrect lowering to a simple COPY. It wouldn't fix *all* of our poison/undef problems, but it would allow us to make progress on some of the most painful IR ones while waiting for that patch to land.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D29121/new/
https://reviews.llvm.org/D29121
More information about the llvm-commits
mailing list