[PATCH] D69188: [llvm-objcopy] Preserve .ARM.attributes section when stripping files

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/CommonOpts.td:43
                 HelpText<"Remove non-allocated sections outside segments. "
-                         ".gnu.warning* sections are not removed">;
+                         ".gnu.warning* and .ARM.attribute sections are not removed">;
 
----------------
jhenderson wrote:
> This goes over the 80 character limit. There's a way to run clang-format on tablegen files, but I can't remember the specific invocation off the top of my head.
Ensure the change is either `git add`ed, or included in the branch,

`git diff -U0 --no-color 'HEAD^' | /path/to/llvm-project/clang/tools/clang-format/clang-format-diff.py -i -p1`

to format .td files.

If you have a newer clang-format, append `-binary=/path/to/clang-format` to the clang-format-diff.py command line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69188/new/

https://reviews.llvm.org/D69188