[PATCH] D69546: [SanitizerCommon] Print the current value of options when printing out help.

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 29 10:54:47 PDT 2019


delcypher added a comment.

Note there is a way to modify this patch so that it does actually show the defaults in the `.inc` files. This would require adding storage for the default values and assigning to it in `CommonFlags::SetDefaults()` (and all other similar sanitizer flag parsers). Then the `CurrentValueAsString()` functions could be renamed to `DefaultValueAsString()` and could be modified to read the default value rather than the current value.

This would be more invasive than this patch and adds additional size to the runtime library, just so we can print out `help=1` in a nicer way which seems wasteful. If this is something that reviewers think we should do then I would suggest doing it as a follow up patch to try to keep this change small.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69546/new/

https://reviews.llvm.org/D69546





More information about the llvm-commits mailing list