[PATCH] D69074: [lld][test] Fix use of escape character in an lld test on Windows

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 29 10:45:23 PDT 2019


MaskRay added a comment.

In D69074#1724858 <https://reviews.llvm.org/D69074#1724858>, @jhenderson wrote:

> Drive-by comment, mostly as an FYI: I'm pretty sure %T has been deprecated because it can cause race conditions (multiple tests can have the same %T) and users should change to create a directory using %t and work inside there.


Thanks for pointing this out! `%T` is used a lot in lld tests. I just created a patch D69572 <https://reviews.llvm.org/D69572> to fix lld/test/ELF tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69074/new/

https://reviews.llvm.org/D69074





More information about the llvm-commits mailing list