[PATCH] D68690: AMDGPU/SILoadStoreOptimizer: fix a likely bug introduced recently

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle added a comment.

Ping

On the issue of a test case: I don't think it's practically possible to hit the crash I was worried about right now, because `AddrIdx[0]` happens to be small enough in all cases that it will be a valid operand index in all cases, and then `hasSameBaseAddress` will bail out for machine instructions of a different class because the register comparison of the first index will fail. However, that's just an artifact of how machine operand indices happen to be laid out today. I still maintain that the change itself is the right way to do things.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68690/new/

https://reviews.llvm.org/D68690