[PATCH] D69558: [ObjectYAML] - Redefine LLVM_YAML_IS_SEQUENCE_VECTOR(llvm::yaml::Hex*) as LLVM_YAML_IS_FLOW_SEQUENCE_VECTOR.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/ObjectYAML/MachO/bogus_load_command.yaml:40
+#CHECK:     PayloadBytes:    [ 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08,
+#CHECK:                        0x09, 0x0A, 0x0B, 0x0C, 0x00, 0x00, 0x00, 0x00 ]
 #CHECK-NOT: LinkEditData:
----------------
grimar wrote:
> jhenderson wrote:
> > Not knowing much about Mach-O, I'm slightly concerned that these extra four zeros were never intended and might be highlighting a bug. @alexshap/@seiya etc might have a better idea?
> Here is the output without this patch applied:
> 
> ```
>   - cmd:             0xDEADBEEF
>     cmdsize:         24
>     PayloadBytes:
>       - 0x01
>       - 0x02
>       - 0x03
>       - 0x04
>       - 0x05
>       - 0x06
>       - 0x07
>       - 0x08
>       - 0x09
>       - 0x0A
>       - 0x0B
>       - 0x0C
>       - 0x00
>       - 0x00
>       - 0x00
>       - 0x00
> ...
> ```
> 
> So these bytes were there before my change, but have never been tested/shown in the test case.
Yes, that's what I assumed. My concern is whether they should be there at all, as they weren't being tested before. It's possible the writer of this test didn't realise they were being emitted and didn't want them to be in this case.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69558/new/

https://reviews.llvm.org/D69558