[PATCH] D69234: [bugpoint] Reduce metadata that does not contribute to crash.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked 3 inline comments as done.
fhahn added inline comments.


================
Comment at: llvm/tools/bugpoint-passes/TestPasses.cpp:175
+    C("bugpoint-crashmetadata", "BugPoint Test Pass - Intentionally crash on "
+                                "instructions with tbaa metadata");
----------------
reames wrote:
> *range* metadata
I've slightly changed the test pass, to additionally require the operand to be an fadd instruction, to avoid the call being the only remaining instruction.


================
Comment at: llvm/tools/bugpoint/CrashDebugger.cpp:864
+  for (Function &F : *M)
+    for (Instruction &Inst : instructions(F)) {
+      Inst.dropUnknownNonDebugMetadata();
----------------
reames wrote:
> Er, it really looks like you should be iterating the instruction set above?
Yes, we should retain metadata on all instructions in Insts/Instructions! This seems to be consistent with other ListReducers. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69234/new/

https://reviews.llvm.org/D69234