[PATCH] D68146: [FileCheck] Implement --ignore-case option.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/FileCheck/check-ignore-case.txt:23
+# CHECK-NEXT: break
\ No newline at end of file

----------------
Kai wrote:
> jhenderson wrote:
> > Nit: no new line at EOF.
> When I download the raw file and look at it in hex mode, then the last byte is 0x0A. That's a new line at EOF, isn't it?
I think this may have been a stale comment for the version I was viewing. At some point, Phabricator said "No new line at end of file" for me. Anyway, the final version you committed doesn't have the issue.


================
Comment at: llvm/test/FileCheck/check-ignore-case.txt:5
+## Check that a regular expression matches independent of case
+# RUN: FileCheck -ignore-case -check-prefix=REGEX -input-file %s %s
+
----------------
MaskRay wrote:
> `-input-file=%s` makes it clear `-input-file` accepts an argument.
> 
> I think @jhenderson may prefer `--input-file=%s`. Binary utilities (almost) exclusively use double-dashed forms now.
> 
> One bad thing with `-input-file` is that it is incompatible with POSIX Utility Syntax Guideline 5 (grouped options). Though FileCheck is not a POSIX utility and it does not necessarily abide by the rules...
Thanks. I may have overly-strong feelings about the -/-- arguments, but I always find it off-putting seeing single-dash long options :)

FWIW, I'm less bothered when it's consistent within a test that only uses executables that don't need to care about single versus double dashes, such as this one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68146/new/

https://reviews.llvm.org/D68146