[PATCH] D66871: [SVE] MVT scalable size queries

[Diana Picus via Phabricator via llvm-commits]

rovka added inline comments.
Herald added a subscriber: wuzish.


================
Comment at: llvm/include/llvm/CodeGen/ValueTypes.h:319
 
-    /// Return the number of bits overwritten by a store of the specified value
+    /// Returns the number of bits overwritten by a store of the specified value
     /// type.
----------------
That's a weird change...


================
Comment at: llvm/utils/TableGen/CodeGenDAGPatterns.cpp:520
     // to a non-vector, it should return false (to avoid removal).
     if (A.isVector() != B.isVector())
       return false;
----------------
Why does LE care about isVector and LT doesn't?

In any case, I think both functions would benefit from being rewritten using std::tie and the corresponding operators.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66871/new/

https://reviews.llvm.org/D66871