[PATCH] D69146: [install-name-tool] Add first bits for install-name-tool

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 29 03:28:20 PDT 2019


jhenderson added a comment.

Okay, only one more minor comment from me, but please get others to approve. I've not really looked at the functional behaviour.



================
Comment at: llvm/test/tools/llvm-objcopy/MachO/install-name-tool-add-rpath.test:16
+# RUN: not llvm-install-name-tool -add_rpath @executable_path/. %t.i386 2>&1 \
+# RUN: | FileCheck --check-prefix=DUPLICATE-RPATH %s
+
----------------
Could you add a couple of extra spaces before the '|', please? That helps me read it as a continuation.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69146/new/

https://reviews.llvm.org/D69146





More information about the llvm-commits mailing list