[PATCH] D68854: [X86] add mayRaiseFPException flag and FPCW registers for X87 instructions

LiuChen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 28 20:11:12 PDT 2019


LiuChen3 added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InstrFPStack.td:708
 def FFREE : FPI<0xDD, MRM0r, (outs), (ins RSTi:$reg), "ffree\t$reg">;
 def FFREEP : FPI<0xDF, MRM0r, (outs), (ins RSTi:$reg), "ffreep\t$reg">;
 
----------------
RKSimon wrote:
> Why did you change this? FFREE/FFREEP leave FPSW in an undefined state
Thanks for your review. I have added 'let Defs = [FPSW]' in class FPI.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68854/new/

https://reviews.llvm.org/D68854





More information about the llvm-commits mailing list