[PATCH] D69536: Recommit "Add a heap alloc site marker field to the ExtraInfo in MachineInstrs"
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 28 15:47:27 PDT 2019
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
================
Comment at: llvm/unittests/CodeGen/MachineInstrTest.cpp:142
+static MCAsmInfo AsmInfo = MCAsmInfo();
+
----------------
Seems like a reasonable fix.
================
Comment at: llvm/unittests/CodeGen/MachineInstrTest.cpp:144-145
+
+class BogusMCContext : public MCContext {
+public:
+ BogusMCContext()
----------------
Why is the "bogus" derived class needed anyway? It seems like you could make a regular MCContext and it would be fine.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69536/new/
https://reviews.llvm.org/D69536
More information about the llvm-commits
mailing list