[PATCH] D69526: [llvm-objcopy] Address post-commit reviews of D69093

[Fangrui Song via Phabricator via llvm-commits]

MaskRay created this revision.
MaskRay added reviewers: grimar, jhenderson, rupprecht.
Herald added subscribers: llvm-commits, seiya, abrachet, jakehehrlich, arichardson, emaste.
Herald added a reviewer: espindola.
Herald added a reviewer: alexshap.
Herald added a project: LLVM.

- Improve comments.
- Reorder the assignment to Obj.SectionNames before the symbol table creation code. Add a test.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D69526

Files:
  llvm/test/tools/llvm-objcopy/ELF/add-symbol-no-symtab.test
  llvm/tools/llvm-objcopy/ELF/Object.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69526.226734.patch
Type: text/x-patch
Size: 6203 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191028/02503b08/attachment.bin>