[llvm] c7557dd - [Remarks] Remove references to ELF support

[Francis Visoiu Mistrih via llvm-commits]

Author: Francis Visoiu Mistrih
Date: 2019-10-28T12:50:46-07:00
New Revision: c7557dd692368d8ac3fc330d698b536e78560ac4

URL: https://github.com/llvm/llvm-project/commit/c7557dd692368d8ac3fc330d698b536e78560ac4
DIFF: https://github.com/llvm/llvm-project/commit/c7557dd692368d8ac3fc330d698b536e78560ac4.diff

LOG: [Remarks] Remove references to ELF support

There is no ELF support at the moment.

Remove all the references to the `.remarks` section.

Added: 
    

Modified: 
    llvm/docs/CommandGuide/llc.rst
    llvm/docs/Remarks.rst
    llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
    llvm/lib/MC/MCObjectFileInfo.cpp
    llvm/test/CodeGen/X86/remarks-section.ll

Removed: 
    


################################################################################
diff  --git a/llvm/docs/CommandGuide/llc.rst b/llvm/docs/CommandGuide/llc.rst
index b4e5dbf1b961..4575e4a543a1 100644
--- a/llvm/docs/CommandGuide/llc.rst
+++ b/llvm/docs/CommandGuide/llc.rst
@@ -149,8 +149,8 @@ End-user Options
 
 .. option:: -remarks-section
 
- Emit the .remarks (ELF) / __remarks (MachO) section which contains metadata
- about remark diagnostics.
+ Emit the __remarks (MachO) section which contains metadata about remark
+ diagnostics.
 
 Tuning/Configuration Options
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~

diff  --git a/llvm/docs/Remarks.rst b/llvm/docs/Remarks.rst
index 0496a5a3f644..653b418e6fd2 100644
--- a/llvm/docs/Remarks.rst
+++ b/llvm/docs/Remarks.rst
@@ -592,7 +592,6 @@ This can be overridden by using the flag ``-remarks-section=<bool>``.
 The section is named:
 
 * ``__LLVM,__remarks`` (MachO)
-* ``.remarks`` (ELF)
 
 C API
 =====

diff  --git a/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp b/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
index b784d2980cbb..3c2395ef6847 100644
--- a/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
+++ b/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
@@ -1380,7 +1380,7 @@ void AsmPrinter::emitRemarksSection(RemarkStreamer &RS) {
                : RemarkSerializer.metaSerializer(OS);
   MetaSerializer->emit();
 
-  // Switch to the right section: .remarks/__remarks.
+  // Switch to the remarks section.
   MCSection *RemarksSection =
       OutContext.getObjectFileInfo()->getRemarksSection();
   OutStreamer->SwitchSection(RemarksSection);

diff  --git a/llvm/lib/MC/MCObjectFileInfo.cpp b/llvm/lib/MC/MCObjectFileInfo.cpp
index 1a9ceb07dd5a..be195928320d 100644
--- a/llvm/lib/MC/MCObjectFileInfo.cpp
+++ b/llvm/lib/MC/MCObjectFileInfo.cpp
@@ -480,9 +480,6 @@ void MCObjectFileInfo::initELFMCObjectFileInfo(const Triple &T, bool Large) {
       Ctx->getELFSection(".eh_frame", EHSectionType, EHSectionFlags);
 
   StackSizesSection = Ctx->getELFSection(".stack_sizes", ELF::SHT_PROGBITS, 0);
-
-  RemarksSection =
-      Ctx->getELFSection(".remarks", ELF::SHT_PROGBITS, ELF::SHF_EXCLUDE);
 }
 
 void MCObjectFileInfo::initCOFFMCObjectFileInfo(const Triple &T) {

diff  --git a/llvm/test/CodeGen/X86/remarks-section.ll b/llvm/test/CodeGen/X86/remarks-section.ll
index 3388e7879dcc..dba20d428a69 100644
--- a/llvm/test/CodeGen/X86/remarks-section.ll
+++ b/llvm/test/CodeGen/X86/remarks-section.ll
@@ -1,4 +1,3 @@
-; RUN: llc < %s -mtriple=x86_64-linux -remarks-section -pass-remarks-output=%/t.yaml | FileCheck -DPATH=%/t.yaml %s
 ; RUN: llc < %s -mtriple=x86_64-darwin -remarks-section -pass-remarks-output=%/t.yaml | FileCheck --check-prefix=CHECK-DARWIN -DPATH=%/t.yaml %s
 ; RUN: llc < %s -mtriple=x86_64-darwin --pass-remarks-format=yaml-strtab -remarks-section -pass-remarks-output=%/t.yaml | FileCheck --check-prefix=CHECK-DARWIN-STRTAB -DPATH=%/t.yaml %s
 
@@ -8,11 +7,6 @@
 ; RUN: llc < %s -mtriple=x86_64-darwin --pass-remarks-format=bitstream -remarks-section=false -pass-remarks-output=%/t.yaml | FileCheck --check-prefix=CHECK-DARWIN-OVERRIDE-BITSTREAM %s
 ; RUN: llc < %s -mtriple=x86_64-darwin --pass-remarks-format=yaml -remarks-section=true -pass-remarks-output=%/t.yaml | FileCheck --check-prefix=CHECK-DARWIN-OVERRIDE-YAML %s
 
-; CHECK-LABEL: func1:
-
-; CHECK: .section .remarks,"e", at progbits
-; CHECK-NEXT: .byte
-
 ; CHECK-DARWIN: .section __LLVM,__remarks,regular,debug
 ; CHECK-DARWIN-NEXT: .byte