[PATCH] D69146: [install-name-tool] Add first bits for install-name-tool

Alexander Shaposhnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 28 12:37:37 PDT 2019


alexshap added a comment.

In D69146#1722098 <https://reviews.llvm.org/D69146#1722098>, @mtrent wrote:

> Would it be possible to add a test that shows llvm-objcopy returning an error if the load command array does not fit in the space between the original end-of-load commands and the start of text sections? Such as a situation where a short dylib path is being replaced with a long one, when -headerpad_max_install_names is not specified.
>
> EDIT: Or if a similar test already exists in objcopy, let me know and I'll have a look.


@mtrent - llvm-objcopy recomputes the layout of the binary (all the offsets, etc), thus we don't have this limitation here, the size of the load commands buffer will change.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69146/new/

https://reviews.llvm.org/D69146





More information about the llvm-commits mailing list