[PATCH] D67556: [ARM][AArch64][DebugInfo] Improve call site instruction interpretation

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: lib/Target/ARM/ARMBaseInstrInfo.cpp:5355
+                                      const MachineOperand *&Destination,
+                                      const MachineOperand *&Source,
+                                      int &Offset) const {
----------------
NikolaPrica wrote:
> aprantl wrote:
> > Sorry for being late in the game. I find it weird for a function called is to have inout parameters. What about doing something along the lines of:
> > 
> > ```
> > struct DestSourcePair {const MachineOperand *Destination, *Source;};
> > Optional<DestSource> isAddImmediate(MI);
> > ```
> That sound better. But since isCopyInstr and isCopyInstrImpl have similar signature maybe I should post such change as a separate NFC patch?
Sure. Either way works.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67556/new/

https://reviews.llvm.org/D67556