[PATCH] D69519: [InstCombine] make icmp vector canonicalization safe for constant with undef elements

[Sanjay Patel via Phabricator via llvm-commits]

spatel updated this revision to Diff 226728.
spatel added a comment.

Patch updated:
Hoist the existing function for replacing undefs and use it. I can make that part an NFC pre-commit, but I kept it all together here in the review for the context.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69519/new/

https://reviews.llvm.org/D69519

Files:
  llvm/include/llvm/IR/Constant.h
  llvm/lib/IR/Constants.cpp
  llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp
  llvm/lib/Transforms/InstCombine/InstCombineShifts.cpp
  llvm/test/Transforms/InstCombine/canonicalize-constant-low-bit-mask-and-icmp-eq-to-icmp-ule.ll
  llvm/test/Transforms/InstCombine/canonicalize-constant-low-bit-mask-and-icmp-sge-to-icmp-sle.ll
  llvm/test/Transforms/InstCombine/canonicalize-constant-low-bit-mask-and-icmp-sle-to-icmp-sle.ll
  llvm/test/Transforms/InstCombine/canonicalize-constant-low-bit-mask-and-icmp-uge-to-icmp-ule.ll
  llvm/test/Transforms/InstCombine/canonicalize-constant-low-bit-mask-and-icmp-ule-to-icmp-ule.ll
  llvm/test/Transforms/InstCombine/icmp-vec.ll
  llvm/test/Transforms/InstCombine/reuse-constant-from-select-in-icmp.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69519.226728.patch
Type: text/x-patch
Size: 11332 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191028/257f47a7/attachment.bin>