[PATCH] D69432: [ARM][Thumb2InstrInfo]: fix default '0' opcode when rewriting frame indeces

David Tellenbach via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 28 12:00:27 PDT 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rGe3a45a24d107: [ARM][Thumb2InstrInfo] Fix default `0` opcode when rewriting frame indices (authored by tellenbach).

Changed prior to commit:
  https://reviews.llvm.org/D69432?vs=226443&id=226724#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69432/new/

https://reviews.llvm.org/D69432

Files:
  llvm/lib/Target/ARM/Thumb2InstrInfo.cpp


Index: llvm/lib/Target/ARM/Thumb2InstrInfo.cpp
===================================================================
--- llvm/lib/Target/ARM/Thumb2InstrInfo.cpp
+++ llvm/lib/Target/ARM/Thumb2InstrInfo.cpp
@@ -388,10 +388,8 @@
     return opcode;
 
   default:
-    break;
+    llvm_unreachable("unknown thumb2 opcode.");
   }
-
-  return 0;
 }
 
 static unsigned
@@ -420,10 +418,8 @@
     return opcode;
 
   default:
-    break;
+    llvm_unreachable("unknown thumb2 opcode.");
   }
-
-  return 0;
 }
 
 static unsigned
@@ -461,10 +457,8 @@
     return opcode;
 
   default:
-    break;
+    llvm_unreachable("unknown thumb2 opcode.");
   }
-
-  return 0;
 }
 
 bool llvm::rewriteT2FrameIndex(MachineInstr &MI, unsigned FrameRegIdx,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69432.226724.patch
Type: text/x-patch
Size: 732 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191028/62551c22/attachment.bin>


More information about the llvm-commits mailing list