[PATCH] D69482: [MachineOuliner][NFC] Refactoring code to make outline rerunning a cleaner diff.

Mon Oct 28 10:46:02 PDT 2019

tellenbach added a comment.

In D69482#1723832 <https://reviews.llvm.org/D69482#1723832>, @plotfi wrote:

> In D69482#1723825 <https://reviews.llvm.org/D69482#1723825>, @tellenbach wrote:
>
> > Maybe I just don't see it but I don't get the reason for creating this new function `doOutline`. Doesn't it basically just call `outline`? Why can't you just add `OutlinedFunctionNum` to `outline` and then call `outline` in `runOnModule`?
> >
> > Please be so kind to clarify this.
>
>
> It’s possible to get greater size reduction through rerunning the outliner repeatedly. I and a couple other folks were looking into this and I noticed that much of the change could be refactored into an nfc change which is preferable.

I see, thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69482/new/

https://reviews.llvm.org/D69482