[PATCH] D69160: [obj2yaml] - Stop triggering UB when dumping corrupted strings.

Mon Oct 28 10:29:37 PDT 2019

grimar marked an inline comment as done.
grimar added inline comments.

================
Comment at: llvm/test/tools/obj2yaml/invalid-section-name.yaml:2-4
+## Here we replace "foo" name with a sequence of characters that
+## do are not representable as unsigned char.
+## We used to have an assert for this case before. 
----------------
jhenderson wrote:
> It looks like @rupprecht's comment (remove "do") here wasn't addressed prior to commit. I also want to suggest a couple of other minor improvements to the comment:
> 
> "Here we replace the section name..."
> "We used to assert for..."
> It looks like @rupprecht's comment (remove "do") here wasn't addressed prior to commit. 

Yes, it was forgotten for a short time, but I addressed it in the follow-up: rL375405.

I'll apply your suggestions tomorrow.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69160/new/

https://reviews.llvm.org/D69160