[PATCH] D29121: [Docs] Add LangRef documention for freeze instruction

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

LGTM w/minor entirely optional comments.

Personally, I'd prefer to see the addition of freeze land, then the optimizer fixes, then the changing of the branch being full UB wording, but I won't insist on that.



================
Comment at: llvm/docs/LangRef.rst:3323
 
-Additionally, undefined behavior occurs if a side effect *depends* on poison.
-This includes side effects that are control dependent on a poisoned branch.
+Additionally, undefined behavior occurs when branching on a poison value.
 
----------------
Suggested minor tweak to wording: integrate this as a bullet item into the previous list.  (i.e. something like "* The condition operand to a branch, select. * The callee operand of a call or invoke.")


================
Comment at: llvm/docs/LangRef.rst:10187
+
+While ``undef`` and ``poison`` pointers can be frozen, the result is a
+non-dereferenceable pointer. See the
----------------
I think this paragraph could be dropped.  It's implied by the previous definition and oddly specific.  Why does this particular implication deserve spelling out and not others?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D29121/new/

https://reviews.llvm.org/D29121