[PATCH] D69508: [ARM] Add vrev32 NEON fp16 patterns
Sjoerd Meijer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 28 07:23:56 PDT 2019
SjoerdMeijer added a comment.
In D69508#1723357 <https://reviews.llvm.org/D69508#1723357>, @dmgreen wrote:
> Yep! That's what I meant. Neon+fullfp16, this fails to select. This test runs in that configuration now. The RHS check lines are missing because it crashes failing to select.
>
> Without fullfp16 you are right that we would never see a f16 vector, so the patterns would never be used. We would promote the f16's to f32's before that point, I believe.
Okidoki, cheers, that makes perfect sense.
Does that mean we only need to add `HasFullFP16` to the `Predicates` of the patterns?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69508/new/
https://reviews.llvm.org/D69508
More information about the llvm-commits
mailing list