[PATCH] D69299: [yaml2obj] - Improve handling of the SHT_GROUP section.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 28 07:21:08 PDT 2019


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with two nits.



================
Comment at: test/tools/yaml2obj/section-link.yaml:48
+
+## Check we link SHT_GROUP to a symbol table by default if it is exists.
+## Check we can use set an arbitrary value for sh_link.
----------------
if it is exists -> if it exists


================
Comment at: test/tools/yaml2obj/section-link.yaml:49
+## Check we link SHT_GROUP to a symbol table by default if it is exists.
+## Check we can use set an arbitrary value for sh_link.
+
----------------
Delete "use". I'd also add "Also" to the start of this sentence: "Also, check we..."


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69299/new/

https://reviews.llvm.org/D69299





More information about the llvm-commits mailing list