[PATCH] D69260: [yaml2obj] - Make .symtab to be not mandatory section for SHT_REL[A] section.

Mon Oct 28 07:16:55 PDT 2019

jhenderson added a comment.

I'm not sure I follow why in most cases adding `Symbols: []` is necessary? Could you explain the detailed impact of this change, with regards to when .symtab will/won't be generated and when the `Link: .symtab` is/is not required for relocation sections now?

================
Comment at: llvm/test/tools/llvm-objcopy/ELF/no-symbol-relocation.test:24
         Type:   R_X86_64_RELATIVE
+## TODO: llvm-objcopy crashes without the following line.
+Symbols: []
----------------
Could you file a bug for this issue, if it doesn't already exist, please?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69260/new/

https://reviews.llvm.org/D69260