[PATCH] D69447: [NFCI][XCOFF][AIX] Skip empty Section during object file generation

[Jason Liu via Phabricator via llvm-commits]

jasonliu marked an inline comment as done.
jasonliu added inline comments.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:151
   uint32_t SymbolTableOffset = 0;
+  int16_t SectionCount = 0;
 
----------------
daltenty wrote:
> Should this be uint16_t?
Originally choose the signed type at the mind set of "don't use unsigned to represent integer that could not be negative." And also, want this to be the same type as the Maximum section index could be. 
But just find out that we are actually writing this SectionCount as unsigned in the object file. So I figure I will just avoid the controversy and use unsigned instead.
Thanks. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69447/new/

https://reviews.llvm.org/D69447