[PATCH] D69439: [APInt] Introduce APIntOps::GetPositionOfMostSignificantDifferentBit()

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM, though I'd suggest a more compact name.



================
Comment at: llvm/include/llvm/ADT/APInt.h:2227
+Optional<unsigned> GetPositionOfMostSignificantDifferentBit(const APInt &A,
+                                                            const APInt &B);
+
----------------
The name seems a bit excessive -- I think `GetMostSignificantDifferingBit` would have the same information content.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69439/new/

https://reviews.llvm.org/D69439