[llvm] 05a9e34 - [YAMLTraits] - Revert a change committed by a mistake in D68983

[via llvm-commits]

Author: georgerim
Date: 2019-10-26T14:52:12+03:00
New Revision: 05a9e344ee35f3b5989df5b95c80a2955389cbbb

URL: https://github.com/llvm/llvm-project/commit/05a9e344ee35f3b5989df5b95c80a2955389cbbb
DIFF: https://github.com/llvm/llvm-project/commit/05a9e344ee35f3b5989df5b95c80a2955389cbbb.diff

LOG: [YAMLTraits] - Revert a change committed by a mistake in D68983

I've accidentally reverted one of my previous patches.
It was not catched by bots because (I guess) they do not
build in debug (we have a test case which triggers an assert
in MSVS when runs without this change).
More info: https://reviews.llvm.org/D68983#inline-624235

Reported by Jordan Rupprecht.

Added: 
    

Modified: 
    llvm/include/llvm/Support/YAMLTraits.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/Support/YAMLTraits.h b/llvm/include/llvm/Support/YAMLTraits.h
index 656020ec49d7..a3bfa7dc4678 100644
--- a/llvm/include/llvm/Support/YAMLTraits.h
+++ b/llvm/include/llvm/Support/YAMLTraits.h
@@ -649,7 +649,8 @@ inline bool isBool(StringRef S) {
 inline QuotingType needsQuotes(StringRef S) {
   if (S.empty())
     return QuotingType::Single;
-  if (isspace(S.front()) || isspace(S.back()))
+  if (isspace(static_cast<unsigned char>(S.front())) ||
+      isspace(static_cast<unsigned char>(S.back())))
     return QuotingType::Single;
   if (isNull(S))
     return QuotingType::Single;