[PATCH] D69003: [dsymutil] Add ${system_libs} to target link libraries

Fri Oct 25 14:56:57 PDT 2019

beanz requested changes to this revision.
beanz added a comment.
This revision now requires changes to proceed.

You don't need to add the library to `dsymutil`. It is not code in `dsymutil` that depends on `libatomic`, it is code in `LLVMSupport` that `dsymutil` is using. By fixing this in `LLVMSupport`, any library linked against `LLVMSupport` will have a linkage to `libatomic` added.

Please don't spend 20 hours testing this patch. I'm very pretty sure this isn't the correct fix.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69003/new/

https://reviews.llvm.org/D69003