[PATCH] D68983: [yaml2obj, obj2yaml] - Add support for SHT_NOTE sections.

Jordan Rupprecht via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 25 14:20:25 PDT 2019


rupprecht added inline comments.


================
Comment at: llvm/include/llvm/Support/YAMLTraits.h:652-653
     return QuotingType::Single;
-  if (isspace(static_cast<unsigned char>(S.front())) ||
-      isspace(static_cast<unsigned char>(S.back())))
     return QuotingType::Single;
----------------
Was this part of the change intentional? This looks like a rebase that accidentally reverted one of your previous patches.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68983/new/

https://reviews.llvm.org/D68983





More information about the llvm-commits mailing list