[PATCH] D69188: [llvm-objcopy] Preserve .ARM.attributes section when stripping files

Fri Oct 25 14:01:52 PDT 2019

MaskRay added a comment.

In D69188#1721664 <https://reviews.llvm.org/D69188#1721664>, @rupprecht wrote:

> LGTM to the change, though I want to resolve this thread before committing:
>
> In D69188#1720890 <https://reviews.llvm.org/D69188#1720890>, @MaskRay wrote:
>
> > I got a misimpression that this is an upstream glibc issue but it turns out that it is not.
> >
> > A glibc ARM maintainer said https://git.launchpad.net/ubuntu/+source/glibc/tree/debian/patches/arm/unsubmitted-ldso-abi-check.diff?h=debian/sid# is only shipped by Ubuntu (Debian?) and probably its derivatives. They can fix the problem by dropping the patch. The glibc upstream does not have the problem.
> >
> > We probably need more input from their side before we proceed to add an llvm-objcopy hack that fixes issues brought by a potentially problematic distribution patch to glibc. In the best case, if Ubuntu developers decide that the glibc patch is a mistake - this is possible, e.g. it used to work around some problems but the package maintainers failed to notice that the patch is no longer needed. We do not need the generic llvm-objcopy patch that may impact users from other distributions.
>
>
> Suppose the glibc patch is dropped from ubuntu (and any other distro that still has this patch), isn't there still a problem that some very large percentage of machines would need to update to pick up the patch, and `llvm-strip` would be producing unusable binaries for the long tail that haven't? Would it be fine to commit this with a TODO to remove it after some appropriate amount of time (1 year maybe)?

We don't receive more complaints, do we? It is also possible for Ubuntu package maintainers to keep this patch in their repositories. We have more choices than accepting this unconditionally and penalizing every other distribution.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69188/new/

https://reviews.llvm.org/D69188