[PATCH] D69296: [ARM] Uses "Sun Style" syntax for section switching

Fri Oct 25 11:02:42 PDT 2019

jcai19 marked 4 inline comments as done.
jcai19 added inline comments.

================
Comment at: llvm/lib/Target/ARM/MCTargetDesc/ARMMCAsmInfo.cpp:79
+
+  // The GNU assembler supports Sun style section switching for Arm targets, and it is used in projects like the Linux kernel.
+  SunStyleELFSectionSwitchSyntax = true;
----------------
nickdesaulniers wrote:
> MaskRay wrote:
> > peter.smith wrote:
> > > Can you break this comment into two lines so that it doesn't go over 80 columns? (https://llvm.org/docs/CodingStandards.html#source-code-width)
> > @jcai19 You can run `git diff -U0 --no-color 'HEAD^' | ~/llvm-project/clang/tools/clang-format/clang-format-diff.py -i -p1` to format the comment.
> Or in vim:
> 
> shift+v to highlight visual lines of comments, then `gqgq` to rewrap lines. May require `set cc=80`.
Thanks all for the comments.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69296/new/

https://reviews.llvm.org/D69296