[PATCH] D69323: Add discussion of git-format-patch to Phabricator.html
Dan Liew via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 25 10:34:45 PDT 2019
delcypher requested changes to this revision.
delcypher added a comment.
This revision now requires changes to proceed.
Thanks for the patch. I didn't know that this information was missing from our docs!
================
Comment at: llvm/docs/Phabricator.rst:65
+Additionally, before sending a patch for review, please also try to ensure it's
+formatted properly. We use ``clang-format`` for this, which has git integration
----------------
I think this needs to be put into its own section because it's not specific to "Requesting a review via the web interface". Formatting is really about preparing for a review rather than requesting it.
Perhaps this information belongs in "How to Submit a Patch" section of the contributing guide and then we could reference that section from this document?
Thoughts?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69323/new/
https://reviews.llvm.org/D69323
More information about the llvm-commits
mailing list