[PATCH] D67322: [LLD][ThinLTO] Handle GUID collision in import global processing

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

LGTM. Small suggestion to expand comment a bit.



================
Comment at: llvm/lib/Transforms/Utils/FunctionImportUtils.cpp:243
+    if (GlobalVariable *V = dyn_cast<GlobalVariable>(&GV)) {
+      // We can have more than one local with the same GUID, find the one
+      // in this module.
----------------
Please add note about this being because of same named but different source files compiled without distinguishing path context.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67322/new/

https://reviews.llvm.org/D67322