[PATCH] D69185: [AArch64] Output the pseudo SPACE in asm and object files

[David Tellenbach via Phabricator via llvm-commits]

tellenbach added inline comments.


================
Comment at: llvm/lib/Target/AArch64/MCTargetDesc/AArch64MCCodeEmitter.cpp:604
     return;
-  } else if (MI.getOpcode() == AArch64::CompilerBarrier) {
-    // This just prevents the compiler from reordering accesses, no actual code.
+  } else if (MI.getOpcode() == AArch64::CompilerBarrier || MI.getOpcode() == AArch64::SPACE) {
+    // CompilerBarrier just prevents the compiler from reordering accesses, and
----------------
Although this case is certainly obvious: Don't use `else` after `return` (https://llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69185/new/

https://reviews.llvm.org/D69185