[PATCH] D69294: [LLD][ELF] Support -[no-]mmap-output-file with F_no_mmap
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 24 19:52:41 PDT 2019
ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: lld/ELF/Writer.cpp:2596
if (!config->relocatable)
flags = FileOutputBuffer::F_executable;
+ if (!config->mmapOutputFile)
----------------
nit: can you replace this `=` with `|=` for consistency?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69294/new/
https://reviews.llvm.org/D69294
More information about the llvm-commits
mailing list