[PATCH] D69295: Optimize SHA1 implementation
Nick Terrell via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 24 18:08:46 PDT 2019
terrelln marked 2 inline comments as done.
terrelln added inline comments.
================
Comment at: llvm/unittests/Support/raw_sha1_ostream_test.cpp:48
+ SHA1 sha1;
+ std::string Input = "123456789012345678901234567890";
+ ASSERT_EQ(Input.size(), 30UL);
----------------
MaskRay wrote:
> This can be a `const char []` or StringRef, can't it?
I add it 4 times on line 55 to get an input that is larger than `BLOCK_LENGTH`. For that I need a string.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69295/new/
https://reviews.llvm.org/D69295
More information about the llvm-commits
mailing list