[PATCH] D69136: Add a heap alloc site marker field to the ExtraInfo in MachineInstrs.

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineInstr.cpp:331-335
+  // Use SetSymbol to indicate that a symbol is being changed, and assert that
+  // a single symbol was not stored out of line.
+  if (SetSymbol && NumPointers == 0)
+    assert(!(Info.is<EIIK_OutOfLine>() && NumPointers == 0) &&
+           "Should never have only a single symbol allocated out-of-line!");
----------------
I think you could get rid of all this and the parameter. It seems trivial with the new code structure.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69136/new/

https://reviews.llvm.org/D69136