[PATCH] D69358: AMDGPU: Fix the broken dominator tree

Changpeng Fang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 24 16:36:07 PDT 2019


cfang added inline comments.


================
Comment at: lib/Target/AMDGPU/SIInstrInfo.cpp:4459
     for (auto &Succ : RemainderBB->successors()) {
-      if (MDT->dominates(&MBB, Succ)) {
+      if (Succ != &MBB && MDT->dominates(&MBB, Succ)) {
         MDT->changeImmediateDominator(Succ, RemainderBB);
----------------
arsenm wrote:
> ->properlyDominates?
right. Thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69358/new/

https://reviews.llvm.org/D69358





More information about the llvm-commits mailing list