[PATCH] D69358: AMDGPU: Fix the broken dominator tree

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: test/CodeGen/AMDGPU/immediate-dominator-fix.ll:4
+
+define void @immediate_dominator_test() {
+; GCN-LABEL: immediate_dominator_test:
----------------
The test and file name need work. This is specifically a problem when the resource descriptor is emitted as a waterfall loop


================
Comment at: test/CodeGen/AMDGPU/immediate-dominator-fix.ll:40
+bb0:
+  %tmp0 = load <2 x i32>, <2 x i32>* undef, align 8
+  %tmp1 = shufflevector <2 x i32> %tmp0, <2 x i32> undef, <4 x i32> <i32 0, i32 1, i32 undef, i32 undef>
----------------
I would prefer using a different way of getting the VGPR resource descriptor. Can you just do the load of the full resource descriptor from memory?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69358/new/

https://reviews.llvm.org/D69358