[PATCH] D69345: [Codegen][ARM] Add float softening for cbrt

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 24 14:26:46 PDT 2019


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM

For promote, you'd need a type with an explicit float specification.  "expand" only applies to ppc_f128.  So I doubt either case is reachable.  But the code is simple enough that the lack of coverage is unlikely to matter.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69345/new/

https://reviews.llvm.org/D69345





More information about the llvm-commits mailing list